5 Commits

Author	SHA1	Message	Date
will.anderson	ab6b52a0b4	self-review 2026-07-18: fix soul SIGABRT double-free + engram route scoping sweep ... 1. engram_neighbors_json (release runtime): BFS frontier/visited strings were el_strdup'd (arena-tracked) but manually freed, so el_request_end() double-freed every one — SIGABRT in http_worker under load (2 prod crashes today via /api/neuron/session/begin and /api/neuron/graph; reproduced and verified fixed with ASAN). Introduced when porting from the dev runtime, which correctly uses plain strdup. Third instance of the arena-vs-manual-free class (after EngramNode 07-15 and idmap keys 07-16). 2. server.el: let-in-if scoping sweep — defaults assigned inside if-blocks never mutated the outer binding, so /api/search and /api/activate always ran with q="", created nodes got node_type=""/salience=0.0, edges got relation=""/weight=0.0, and save/load with no path hit engram_save(""). Rewritten to the let-if-else expression form. /api/activate now also rejects empty queries instead of wiping carried WM weights. 3. engram_activate: retrieval reinforcement (ACT-R base-level learning) — nodes promoted to WM that survive both capacity caps now get last_activated/activation_count updated, so frequently retrieved memories decay slower than abandoned ones. Scoped to promoted-only to avoid flattening dampening across BFS fan-out.	2026-07-18 08:48:04 -05:00
will.anderson	cfe8cb1c80	fix(release-snapshot): fflush stdout in println and update Knowledge threshold	2026-07-01 11:25:09 -05:00
will.anderson	deb0520551	feat(runtime): port engram_load_merge to released runtime + add missing WM headers ... engram_load_merge was added to el-compiler/runtime in 35c1897 but never ported to the released runtime used by Engram and the soul daemon. awareness.el calls engram_load_merge in its sync refresh cycle; without this function in lang/releases/v1.0.0-20260501/el_runtime.c the soul daemon fails to compile. Also adds header declarations for engram_wm_count, engram_wm_avg_weight, engram_wm_top_json, and engram_load_merge — all four were added as implementations (da116b2 / 35c1897) but their prototypes were missing from el_runtime.h, causing implicit-function-declaration warnings and potential ABI breakage on stricter compilers. Identified during self-review 2026-06-30.	2026-06-30 08:57:22 -05:00
will.anderson	da116b2884	self-review 2026-06-30: WM cap, breakthrough floor, ISE exclusion + route ... Port critical WM fixes from self-review 2026-06-26 branch (f7bd99a) that were never merged to HEAD. Running binary had these fixes; source did not — rebuild would have silently regressed all three improvements. 1. ENGRAM_BREAKTHROUGH_WEIGHT 0.25→0.10 With 0.25, naturally-promoted nodes (threshold ≥0.15) decayed below the breakthrough floor within one activation call and lost their WM slot to fresh breakthrough candidates. All 524/525 WM nodes were at floor = useless. Invariant: BREAKTHROUGH_WEIGHT < min(type_thresholds = 0.15 Canonical). 2. ENGRAM_WM_CAP=24 with Pass 4 (per-call) + Pass 5 (global) enforcement Without cap, broad curiosity seeds promote 500+ nodes simultaneously. wm_avg_weight collapses, goal-bias differentiation is lost. Verified: "knowledge" query now promotes exactly 24 nodes (was 525). Cowan (2001) cognitive basis: WM capacity ~4 chunks; 24 allows rich multi-topic context. 3. ISE exclusion from WM (Pass 2 guard) InternalStateEvent JSON content ("knowledge", "memory", etc.) triggered lexical seeding → suppression accumulation → breakthrough at floor. ISEs are observability-only and must never surface in context compilation. suppression_count cleared so ISEs never build toward breakthrough. 4. route_create_ise importance fix (0.5→0.3) Corrects mismatch between HTTP route and awareness.el in-process fallback. Also adds body comment clarifying auth-exempt rationale. SYNAPSE (arXiv 2601.02744) validates WM cap design and ISE exclusion principle. Next priority: cosine similarity seeding to complement lexical BFS.	2026-06-30 08:48:19 -05:00
Will Anderson	1ae68962cf	restructure: move el compiler content into lang/	2026-05-05 01:38:51 -05:00