Files
el/engram/test/test_interoception_p0_emb.c
T
bigmerge bacaf3d39c
El SDK CI - dev / build-and-test (pull_request) Failing after 4m49s
engram: reconcile M8 HNSW vindex (#109) onto current dev, restore 3 fixes the branch predated
Lands feat/reframe-region-setop (PR #109: native set-based reframe_region,
decorator-as-seam @route port, teacher-summon, and the M8.1 activate-latency
work — lazy-memoized cosq via eg_cosq_at + engram_vindex HNSW-accelerated
seed discovery + vindex_harvest_from_store/vindex_bench oracle) onto dev's
actual current HEAD, plus engram-tiered-storage's still-unique test suite.

RECONCILING #109 WITH engram-tiered-storage (M4-M10 HNSW/geometry/reason/
verify work): not a two-way merge. engram_vindex.c's HNSW core (search_layer/
select_neighbors/prune_links/insert) is BYTE-IDENTICAL between the two
branches; #109's copy is a strict superset (adds vindex_harvest_from_store,
used by vindex_bench.c's brute-force-vs-HNSW oracle). engram_reason.c and
engram_verify.c are also byte-identical. #109's own branch point already
carried engram-tiered-storage's M4-M10 lineage forward, so there was nothing
left to merge into #109 for those files. The one thing engram-tiered-storage
had that #109's tree dropped: its full test suite (test_vindex.c,
test_geometry.c, test_reason.c, test_verify.c, test_m7_traversal.c, the
interoception P0-P5 tests, bufpool/compaction tests, and their run_*.sh
harnesses) — ported over here unchanged.

WHY THIS NEEDED HAND RECONCILIATION, NOT A MECHANICAL MERGE: #109's branch
forked from dev on 2026-08-14 15:40 (before restructure-adjacent history
diverged the file's merge-base for `git merge` — it presented as an add/add
conflict). A straight two-dot diff (dev tip -> PR tip) applied cleanly, but
it silently reverted THREE dev fixes landed on 2026-08-14/15, after the
branch point, that the PR's diff had no way to know about:

  1. qgate rescale (2026-08-14 self-review): PR's lazy eg_cosq_at rewrite of
     the query-aware propagation gate dropped the shift-and-floor rescale
     about ENGRAM_EMBED_S0 (measured: unrelated-pair median 0.562->raw gate
     0.67, i.e. "a small tax, not a gate"). Restored the rescale, wrapped
     around the lazy accessor -- the PR's actual improvement (WHEN cosq[oi]
     is computed) is orthogonal to WHAT it gates on and both are kept.
  2. Eviction cause decomposition (2026-08-14 self-review): dev decomposes
     wm_evicted into evict_floor/evict_cap/evict_bll so WM churn is
     diagnosable (identity: evicted == floor+cap+bll+dup_wm+dup_wm_global).
     PR's tree predates this and dropped all three counters + their JSON
     stats fields. Restored declarations, all 4 direct increment sites, the
     eg_wm_carry_over bll increment, and the act-stats JSON fields --
     alongside (not instead of) the PR's own P4 afferent / API-reshape
     counters already in that same struct/JSON.
  3. Hebbian link-formation selection (2026-08-15 self-review, TODAY): dev
     selects the STRONGEST qualifying candidate for consolidation each call;
     PR's tree predates this and reverted to hash-slot order (arbitrary wrt
     association strength) for edge formation -- the one path that writes
     PERMANENT structure. Restored the strongest-candidate while-loop,
     keeping the PR's own genuine improvement at that site
     (engram_adj_on_edge_added incremental-index append instead of a bare
     adj_dirty=1 full-rebuild flag).

engram/src/server.el's 3-way conflicts (autoconnect_on/ise_offgraph_on env
flags, /api/nodes connected-count in responses) were pure additive: dev's
side was empty, PR's side added the feature. Took PR's side whole.

VERIFIED (nsbx sandbox only, live :8742/:7770 never touched):
  - cc -std=c11 -O2, clean link against the real engram/src/server.el via
    elc, zero errors.
  - vindex_bench (built standalone, read-only harvest) against the real
    production store clone (13,671 embedded nodes, 768-dim nomic-embed-text):
    recall@10 = 1.0000 at ef 64/128/200; HNSW search 0.28-0.79ms/query vs
    2.03ms/query brute-force oracle (2.6x-7.2x). HNSW build itself: 46.5s
    for the full 13,671-node set -- see the flagged risk below.
  - Booted the reconciled binary in an isolated nsbx sandbox (:8905, cloned
    snapshot of the live store, 13,424 nodes / 37,656 edges) and called
    /api/activate for real: first call after boot 41.5s (pays the one-time
    HNSW build inline -- matches the standalone bench), second/third calls
    356ms/605ms, no crash, correct results, act-stats JSON (including the
    restored evict_floor/cap/bll fields) reads correctly.

KNOWN RISK TO FLAG BEFORE ANY LIVE CUTOVER (not fixed here; out of scope for
this dev-only land per instructions not to touch :8742/:7770): eg_vindex_sync
builds the HNSW index synchronously, inline, on the first engram_activate()
call after every process start (or index invalidation). On the real node
count that is a ~46s blocking stall on a single-threaded server -- the first
request after every restart (or its concurrent siblings) waits the full
build. Recommend a background/incremental build (or a bounded per-call build
budget) before this ever reaches the live daemon. See PR description / final
report for the fuller writeup.
2026-08-15 16:46:44 -05:00

80 lines
3.5 KiB
C

/* test_interoception_p0_emb.c — M-INTEROCEPTION Priority 0.
*
* Verifies the new READ-ONLY builtin engram_scan_nodes_emb_json(limit,offset):
* - every emitted node carries emb_dim and an emb JSON array of that length,
* - nodes without an embedding emit emb_dim:0 / emb:[],
* - pagination (limit/offset) is honoured,
* - the count matches engram_node_count,
* - the EXISTING engram_scan_nodes_json path is byte-unchanged (no emb field),
* i.e. the addition is purely additive / behavior-neutral.
*
* Pure-C harness (no elc). We craft a snapshot with real emb vectors, load it
* (engram_load parses "emb" comma-lists into node->emb via eg_parse_emb), then
* dump via both scan paths. Assertions live in run_interoception_p0.sh.
*/
#include "el_runtime.h"
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
static el_val_t S(const char* s){ return EL_STR(s); }
/* 16-d embedding as a comma list (>=8 required by eg_parse_emb). */
static void emb_list(char* out, size_t cap, int dim, double base){
size_t o = 0;
for (int i = 0; i < dim; i++){
o += snprintf(out+o, cap-o, "%s%.4f", i?",":"", base + 0.01*i);
}
}
int main(int argc, char** argv){
if (argc < 2){ fprintf(stderr, "usage: %s <dir>\n", argv[0]); return 2; }
const char* dir = argv[1];
char snap[1024]; snprintf(snap, sizeof snap, "%s/seed.json", dir);
char e1[512], e2[512];
emb_list(e1, sizeof e1, 16, 0.10);
emb_list(e2, sizeof e2, 16, 0.50);
/* Two embedded nodes (distinct salience → deterministic sort order) and one
* un-embedded node. */
FILE* f = fopen(snap, "w");
if (!f){ perror("fopen"); return 2; }
fprintf(f,
"{\"nodes\":["
"{\"id\":\"n-high\",\"content\":\"high salience embedded\",\"node_type\":\"Concept\","
"\"label\":\"emb-high\",\"tier\":\"Semantic\",\"salience\":0.9,\"importance\":0.8,"
"\"confidence\":1.0,\"created_at\":1000,\"emb\":\"%s\"},"
"{\"id\":\"n-mid\",\"content\":\"mid salience embedded\",\"node_type\":\"Concept\","
"\"label\":\"emb-mid\",\"tier\":\"Semantic\",\"salience\":0.5,\"importance\":0.5,"
"\"confidence\":1.0,\"created_at\":2000,\"emb\":\"%s\"},"
"{\"id\":\"n-low\",\"content\":\"low salience no embedding\",\"node_type\":\"Fact\","
"\"label\":\"noemb-low\",\"tier\":\"Semantic\",\"salience\":0.1,\"importance\":0.2,"
"\"confidence\":1.0,\"created_at\":3000}"
"],\"edges\":[]}", e1, e2);
fclose(f);
if (!engram_load(S(snap))){ fprintf(stderr, "load failed\n"); return 2; }
long long nc = (long long)(int64_t)engram_node_count();
printf("node_count=%lld\n", nc);
/* full page */
el_val_t all = engram_scan_nodes_emb_json((el_val_t)256, (el_val_t)0);
char p[1024];
snprintf(p, sizeof p, "%s/emb_all.json", dir);
f = fopen(p, "w"); fputs(EL_CSTR(all), f); fclose(f);
/* pagination: one node at offset 0 and one at offset 1 */
el_val_t pg0 = engram_scan_nodes_emb_json((el_val_t)1, (el_val_t)0);
el_val_t pg1 = engram_scan_nodes_emb_json((el_val_t)1, (el_val_t)1);
snprintf(p, sizeof p, "%s/emb_pg0.json", dir); f = fopen(p, "w"); fputs(EL_CSTR(pg0), f); fclose(f);
snprintf(p, sizeof p, "%s/emb_pg1.json", dir); f = fopen(p, "w"); fputs(EL_CSTR(pg1), f); fclose(f);
/* existing path — must be unchanged / carry NO emb */
el_val_t plain = engram_scan_nodes_json((el_val_t)256, (el_val_t)0);
snprintf(p, sizeof p, "%s/plain.json", dir); f = fopen(p, "w"); fputs(EL_CSTR(plain), f); fclose(f);
printf("wrote dumps to %s\n", dir);
return 0;
}