Refactor integration test DecodeJSON calls to use generic return value (#37432)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
@@ -17,13 +17,12 @@ import (
|
||||
func TestTopicSearch(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
searchURL, _ := url.Parse("/explore/topics/search")
|
||||
var topics struct {
|
||||
TopicNames []*api.TopicResponse `json:"topics"`
|
||||
}
|
||||
|
||||
// search all topics
|
||||
res := MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
||||
DecodeJSON(t, res, &topics)
|
||||
topics := DecodeJSON(t, res, &struct {
|
||||
TopicNames []*api.TopicResponse `json:"topics"`
|
||||
}{})
|
||||
assert.Len(t, topics.TopicNames, 6)
|
||||
assert.Equal(t, "6", res.Header().Get("x-total-count"))
|
||||
|
||||
@@ -33,7 +32,9 @@ func TestTopicSearch(t *testing.T) {
|
||||
|
||||
searchURL.RawQuery = query.Encode()
|
||||
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
||||
DecodeJSON(t, res, &topics)
|
||||
topics = DecodeJSON(t, res, &struct {
|
||||
TopicNames []*api.TopicResponse `json:"topics"`
|
||||
}{})
|
||||
assert.Len(t, topics.TopicNames, 4)
|
||||
assert.Equal(t, "6", res.Header().Get("x-total-count"))
|
||||
|
||||
@@ -43,7 +44,9 @@ func TestTopicSearch(t *testing.T) {
|
||||
|
||||
searchURL.RawQuery = query.Encode()
|
||||
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
||||
DecodeJSON(t, res, &topics)
|
||||
topics = DecodeJSON(t, res, &struct {
|
||||
TopicNames []*api.TopicResponse `json:"topics"`
|
||||
}{})
|
||||
assert.Len(t, topics.TopicNames, 2)
|
||||
assert.Equal(t, "6", res.Header().Get("x-total-count"))
|
||||
|
||||
@@ -53,14 +56,18 @@ func TestTopicSearch(t *testing.T) {
|
||||
query.Add("q", "topic")
|
||||
searchURL.RawQuery = query.Encode()
|
||||
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
||||
DecodeJSON(t, res, &topics)
|
||||
topics = DecodeJSON(t, res, &struct {
|
||||
TopicNames []*api.TopicResponse `json:"topics"`
|
||||
}{})
|
||||
assert.Len(t, topics.TopicNames, 2)
|
||||
|
||||
topics.TopicNames = nil
|
||||
query.Set("q", "database")
|
||||
searchURL.RawQuery = query.Encode()
|
||||
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
||||
DecodeJSON(t, res, &topics)
|
||||
topics = DecodeJSON(t, res, &struct {
|
||||
TopicNames []*api.TopicResponse `json:"topics"`
|
||||
}{})
|
||||
if assert.Len(t, topics.TopicNames, 1) {
|
||||
assert.EqualValues(t, 2, topics.TopicNames[0].ID)
|
||||
assert.Equal(t, "database", topics.TopicNames[0].Name)
|
||||
|
||||
Reference in New Issue
Block a user