refactor(templates): remove ctxData from tmpl files, use ctx.RootData instead (#37567)

Sub-templates have direct access to `ctx.RootData` (the root data map),
so there is no need for callers to explicitly pass it as `ctxData` via `dict`.

Also fix #37569 by the way

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Copilot
2026-05-06 18:21:48 +00:00
committed by GitHub
parent ebc058f682
commit b093c2c43c
95 changed files with 140 additions and 140 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings actions")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings actions")}}
<div class="repo-setting-content">
{{if eq .PageType "runners"}}
{{template "shared/actions/runner_list" .}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings edit")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings edit")}}
<div class="repo-setting-content">
{{if .Repository.IsArchived}}
<div class="ui warning message tw-text-center">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings collaboration")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings collaboration")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.collaboration"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.deploy_keys"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings edit githook")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings edit githook")}}
<div class="repo-setting-content">
<form class="ui form" action="{{.Link}}" method="post">
<h4 class="ui top attached header flex-left-right">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings githooks")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings githooks")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.githooks"}}
+5 -5
View File
@@ -1,10 +1,10 @@
{{template "base/head" .ctxData}}
<div role="main" aria-label="{{.ctxData.Title}}" class="page-content {{.pageClass}}">
{{template "repo/header" .ctxData}}
{{template "base/head" ctx.RootData}}
<div role="main" aria-label="{{ctx.RootData.Title}}" class="page-content {{.pageClass}}">
{{template "repo/header" ctx.RootData}}
<div class="ui container flex-container">
{{template "repo/settings/navbar" .ctxData}}
{{template "repo/settings/navbar" ctx.RootData}}
<div class="flex-container-main">
{{template "base/alert" .ctxData}}
{{template "base/alert" ctx.RootData}}
{{/* block: repo-setting-content */}}
{{if false}}{{/* to make html structure "likely" complete to prevent IDE warnings */}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings lfs")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings lfs")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.lfs_filelist"}} ({{ctx.Locale.Tr "admin.total" .Total}})
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings lfs")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings lfs")}}
<div class="user-main-content twelve wide column content repository file list">
<div class="tab-size-8 non-diff-file-content">
<h4 class="ui top attached header">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings lfs")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings lfs")}}
<div class="user-main-content twelve wide column content repository file list">
<div class="tab-size-8 non-diff-file-content">
<h4 class="ui top attached header">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings lfs")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings lfs")}}
<div class="user-main-content twelve wide column content repository file list">
<div class="tab-size-8 non-diff-file-content">
<h4 class="ui top attached header">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings lfs")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings lfs")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.lfs_pointers.found" .NumPointers .NumAssociated .NumNotAssociated .NumNoExist}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings options")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings options")}}
<div class="user-main-content twelve wide column">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.basic_settings"}}
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings branches")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings branches")}}
<div class="repo-setting-content">
<form class="ui form" action="{{.Link}}" method="post">
<h4 class="ui top attached header">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "repo.settings.public_access"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings runners")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings runners")}}
<div class="repo-setting-content">
{{template "shared/actions/runner_edit" .}}
</div>
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings")}}
<div class="repo-setting-content">
{{template "shared/secrets/add_list" .}}
</div>
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings edit")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings edit")}}
<div class="repo-setting-content">
{{if .Repository.IsArchived}}
<div class="ui warning message tw-text-center">
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings webhooks")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings webhooks")}}
<div class="repo-setting-content">
{{template "repo/settings/webhook/base_list" .}}
</div>
+2 -2
View File
@@ -1,7 +1,7 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings new webhook")}}
{{template "repo/settings/layout_head" (dict "pageClass" "repository settings new webhook")}}
<div class="repo-setting-content">
{{$CustomHeaderTitle := ctx.Locale.Tr "repo.settings.update_webhook"}}
{{if .PageIsSettingsHooksNew}}{{$CustomHeaderTitle = ctx.Locale.Tr "repo.settings.add_webhook"}}{{end}}
{{template "webhook/new" (dict "ctxData" . "CustomHeaderTitle" $CustomHeaderTitle)}}
{{template "webhook/new" (dict "CustomHeaderTitle" $CustomHeaderTitle)}}
</div>
{{template "repo/settings/layout_footer" .}}