refactor(templates): remove ctxData from tmpl files, use ctx.RootData instead (#37567)

Sub-templates have direct access to `ctx.RootData` (the root data map),
so there is no need for callers to explicitly pass it as `ctxData` via `dict`.

Also fix #37569 by the way

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Copilot
2026-05-06 18:21:48 +00:00
committed by GitHub
parent ebc058f682
commit b093c2c43c
95 changed files with 140 additions and 140 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings account")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings account")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "settings.password"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings actions")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings actions")}}
<div class="user-setting-content">
{{if eq .PageType "secrets"}}
{{template "shared/secrets/add_list" .}}
+1 -1
View File
@@ -1,3 +1,3 @@
{{template "user/settings/layout_head" (dict "ctxData" .)}}
{{template "user/settings/layout_head" (dict)}}
{{template "shared/actions/owner_general_settings" .}}
{{template "user/settings/layout_footer" .}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings")}}
<div class="user-setting-content">
<!-- Theme -->
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings applications")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings applications")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "settings.manage_access_token"}}
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings applications")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings applications")}}
<div class="user-setting-content">
{{template "user/settings/applications_oauth2_edit_form" .}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings blocked_users")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings blocked_users")}}
<div class="user-setting-content">
{{template "shared/user/blocked_users" .}}
</div>
+2 -2
View File
@@ -1,7 +1,7 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings new webhook")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings new webhook")}}
<div class="user-setting-content">
{{$CustomHeaderTitle := ctx.Locale.Tr "repo.settings.update_webhook"}}
{{if .PageIsSettingsHooksNew}}{{$CustomHeaderTitle = ctx.Locale.Tr "repo.settings.add_webhook"}}{{end}}
{{template "webhook/new" (dict "ctxData" . "CustomHeaderTitle" $CustomHeaderTitle)}}
{{template "webhook/new" (dict "CustomHeaderTitle" $CustomHeaderTitle)}}
</div>
{{template "user/settings/layout_footer" .}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings webhooks")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings webhooks")}}
<div class="user-setting-content">
{{template "repo/settings/webhook/base_list" .}}
</div>
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings sshkeys")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings sshkeys")}}
<div class="user-setting-content">
{{if not ($.UserDisabledFeatures.Contains "manage_ssh_keys")}}
{{template "user/settings/keys_ssh" .}}
+4 -4
View File
@@ -1,9 +1,9 @@
{{template "base/head" .ctxData}}
<div role="main" aria-label="{{.ctxData.Title}}" class="page-content {{.pageClass}}">
{{template "base/head" ctx.RootData}}
<div role="main" aria-label="{{ctx.RootData.Title}}" class="page-content {{.pageClass}}">
<div class="ui container flex-container">
{{template "user/settings/navbar" .ctxData}}
{{template "user/settings/navbar" ctx.RootData}}
<div class="flex-container-main">
{{template "base/alert" .ctxData}}
{{template "base/alert" ctx.RootData}}
{{/* block: user-setting-content */}}
{{if false}}{{/* to make html structure "likely" complete to prevent IDE warnings */}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "notifications"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings organization")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings organization")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "settings.orgs"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings packages")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings packages")}}
<div class="user-setting-content">
{{template "package/shared/cleanup_rules/list" .}}
{{template "package/shared/cargo" .}}
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings packages")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings packages")}}
<div class="user-setting-content">
{{template "package/shared/cleanup_rules/edit" .}}
</div>
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user packages admin")}}
{{template "user/settings/layout_head" (dict "pageClass" "user packages admin")}}
<div class="user-setting-content">
{{template "package/shared/cleanup_rules/preview" .}}
</div>
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings profile")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings profile")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "settings.public_profile"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings repos")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings repos")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "settings.repos"}}
+1 -1
View File
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings runners")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings runners")}}
<div class="user-setting-content">
{{template "shared/actions/runner_edit" .}}
</div>
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings security")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings security")}}
{{if not ($.UserDisabledFeatures.Contains "manage_mfa" "manage_credentials")}}
<div class="user-setting-content">
{{if not ($.UserDisabledFeatures.Contains "manage_mfa")}}
@@ -1,4 +1,4 @@
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings twofa")}}
{{template "user/settings/layout_head" (dict "pageClass" "user settings twofa")}}
<div class="user-setting-content">
<h4 class="ui top attached header">
{{ctx.Locale.Tr "settings.twofa_enroll"}}