From dc36fe0157be557dd653b6a79926580ee88577f3 Mon Sep 17 00:00:00 2001
From: Will Anderson <will.anderson@neurontechnologies.ai>
Date: Sat, 9 May 2026 17:39:04 -0500
Subject: [PATCH] =?UTF-8?q?Skip=20smoke=20test=20for=20PR=20builds=20?=
 =?UTF-8?q?=E2=80=94=20compile+image-build=20is=20sufficient=20gate?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .gitea/workflows/dev.yaml | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/.gitea/workflows/dev.yaml b/.gitea/workflows/dev.yaml
index 29faae3..a911438 100644
--- a/.gitea/workflows/dev.yaml
+++ b/.gitea/workflows/dev.yaml
@@ -146,6 +146,13 @@ jobs:
           rm -f src/js/el_runtime.js
 
       # ── Docker build + smoke test ─────────────────────────────────────────
+      #
+      # PR builds: binary is compiled by committed bin/elb-linux-amd64 which
+      # may lag behind the current El SDK. Smoke-testing that binary is
+      # unreliable (glibc mismatch in Docker; potential codegen differences
+      # when run directly). PRs only need to prove the code *compiles* and
+      # the Docker image *builds* — the authoritative runtime check runs on
+      # push to dev (ci-base SDK, always current).
 
       - name: Compute image tag
         id: tag
@@ -156,9 +163,8 @@ jobs:
 
       - name: Create soul-demo-image.tar placeholder
         # Dockerfile.stage COPYs this file (used by k3s at runtime).
-        # For the dev smoke test the k3s import fails silently — the landing
-        # server still comes up on :8080. Real tar is built by build-stage.sh
-        # in the deploy pipeline; here we just need the COPY to succeed.
+        # We only need the COPY to succeed here; real tar is built by
+        # build-stage.sh in the deploy pipeline.
         run: touch dist/soul-demo-image.tar
 
       - name: Build Docker image (local only — no push)
@@ -177,10 +183,11 @@ jobs:
             .
 
       - name: Local smoke test
-        # Run the binary directly on the runner — avoids the glibc version
-        # mismatch that occurs when the runner-compiled binary is run inside
-        # the Docker base image (which ships an older glibc). The Docker build
-        # step above already verified the image compiles correctly.
+        # Push builds only: binary compiled from ci-base is current and
+        # compatible with the runner glibc. Skipped for pull_request events
+        # because the committed bin/elb may produce a binary that requires
+        # a newer glibc than what the runner environment provides.
+        if: github.event_name != 'pull_request'
         run: |
           set -euo pipefail
           PORT=8080 dist/neuron-landing &