neuron-technologies/neuron
2
0
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(app): contain right panel suspense (#39080)

Browse Source
This commit is contained in:
Brendan Allan
2026-07-27 17:56:13 +08:00
committed by GitHub
parent bfb012544e
commit 68f574f872
1 changed files with 42 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/src/pages/session.tsx
+42 -37
View File
@@ -6,6 +6,7 @@ import {
batch, batch,
ErrorBoundary, ErrorBoundary,
onCleanup, onCleanup,
Suspense,
Show, Show,
Match, Match,
Switch, Switch,
@@ -2297,49 +2298,53 @@ export default function Page() {
</div> </div>
<Show when={!newSessionDesign() && desktopSidePanelOpen()}> <Show when={!newSessionDesign() && desktopSidePanelOpen()}>
<SessionSidePanel <Suspense>
canReview={canReview} <SessionSidePanel
diffs={reviewDiffs} canReview={canReview}
diffsReady={reviewReady} diffs={reviewDiffs}
empty={reviewEmptyText} diffsReady={reviewReady}
hasReview={hasReview} empty={reviewEmptyText}
reviewHasFocusableContent={hasReview} hasReview={hasReview}
reviewCount={reviewCount} reviewHasFocusableContent={hasReview}
reviewPanel={reviewPanel} reviewCount={reviewCount}
activeDiff={activeReviewFile()} reviewPanel={reviewPanel}
focusReviewDiff={focusReviewDiff} activeDiff={activeReviewFile()}
reviewSnap={ui.reviewSnap} focusReviewDiff={focusReviewDiff}
size={size} reviewSnap={ui.reviewSnap}
/> size={size}
/>
</Suspense>
</Show> </Show>
<Show when={newSessionDesign()}> <Show when={newSessionDesign()}>
<Show when={isDesktop() ? desktopV2PanelLayout().visible : terminalOpen()}> <Show when={isDesktop() ? desktopV2PanelLayout().visible : terminalOpen()}>
<div class="min-w-0 h-full flex flex-1 flex-col"> <div class="min-w-0 h-full flex flex-1 flex-col">
<Show when={isDesktop() && (desktopV2ReviewOpen() || desktopFileTreeOpen())}> <Show when={isDesktop() && (desktopV2ReviewOpen() || desktopFileTreeOpen())}>
<div class="min-h-0 flex-1"> <div class="min-h-0 flex-1">
<SessionSidePanel <Suspense>
canReview={canReview} <SessionSidePanel
diffs={reviewDiffs} canReview={canReview}
diffsReady={reviewReady} diffs={reviewDiffs}
empty={reviewEmptyText} diffsReady={reviewReady}
hasReview={hasReview} empty={reviewEmptyText}
reviewHasFocusableContent={() => hasReview() || reviewV2State.sidebarOpened()} hasReview={hasReview}
reviewCount={reviewCount} reviewHasFocusableContent={() => hasReview() || reviewV2State.sidebarOpened()}
reviewPanel={reviewPanelV2} reviewCount={reviewCount}
reviewSidebarToggle={(disabled) => ( reviewPanel={reviewPanelV2}
<SessionReviewV2SidebarToggle reviewSidebarToggle={(disabled) => (
opened={reviewV2State.sidebarOpened()} <SessionReviewV2SidebarToggle
disabled={disabled} opened={reviewV2State.sidebarOpened()}
onToggle={reviewV2State.toggleSidebar} disabled={disabled}
/> onToggle={reviewV2State.toggleSidebar}
)} />
fileBrowserState={reviewV2State} )}
activeDiff={activeReviewFile()} fileBrowserState={reviewV2State}
focusReviewDiff={focusReviewDiff} activeDiff={activeReviewFile()}
reviewSnap={ui.reviewSnap} focusReviewDiff={focusReviewDiff}
size={size} reviewSnap={ui.reviewSnap}
stacked={desktopV2PanelLayout().stacked} size={size}
/> stacked={desktopV2PanelLayout().stacked}
/>
</Suspense>
</div> </div>
</Show> </Show>
<Show when={desktopV2PanelLayout().stacked}> <Show when={desktopV2PanelLayout().stacked}>