fix/test: PR #21 review — guard, safety Bell, api write-back, temp paths
Neuron Soul CI / build (pull_request) Failing after 13m22s

fix(soul): add HTTP-engram guard to safe_to_seed — when ENGRAM_URL is set
the HTTP Engram owns persistence; genesis must never save to local snapshot
regardless of node counts (was: guard_disk forced to empty string, making
the ratio check vacuously true and allowing init_soul_edges+engram_save).

fix(soul): use multiplication form for ratio guard — node_count * 16000 <
disk_len avoids floor-division truncation that underestimated boundary files
(250KB / 16000 = 15.6, floors to 15; a 15-node graph wrongly passed old guard).

fix(chat): add safety_augment_system to handle_chat_as_soul,
handle_dharma_room_turn, and handle_dharma_room_turn_agentic — all three
called the LLM without Hard Bell evaluation, leaving users in dharma rooms
without crisis resource routing.

fix(neuron-api): add api_persisted read-back to handle_api_define_process —
was the only write handler that returned ok:true without verifying the node
was actually written to engram.

fix(routes): unique temp file path in connectd_post — replaces fixed
/tmp/neuron-connectors-req.json with a timestamped path to prevent
collision if concurrency is added or two soul instances share a machine.

test: add tests/test_bell_safety.el — covers safety_detect_bell_level
(none/soft/hard), safety_classify_hard_bell (abuse/self_harm routing),
safety_normalize (smart-quote), safety_augment_system, and
handle_safety_contact_post (validation + read-back).

test: add tests/test_soul_guard.el — pure-function logic tests for the
safe_to_seed predicate: 200KB boundary, 47MB/63-node clobber scenario,
HTTP-engram mode, multiplication vs division truncation at 250KB.

test: add tests/test_api_define_process.el — verifies the define_process
write is read-back verified after the fix.
This commit is contained in:
2026-06-17 13:04:12 -05:00
parent 5ddb860201
commit 8b692e4666
7 changed files with 520 additions and 2 deletions
+9
View File
@@ -909,6 +909,9 @@ fn handle_chat_as_soul(body: String) -> String {
let req_model: String = json_get(body, "model")
let model: String = if str_eq(req_model, "") { chat_default_model() } else { req_model }
// Hard Bell: pre-LLM safety evaluation multi-soul room conversations are real interactions.
let system_prompt = safety_augment_system(system_prompt, eff_message)
let raw_response: String = llm_call_system(model, system_prompt, eff_message)
let is_error: Bool = str_starts_with(raw_response, "{\"error\"")
@@ -955,6 +958,9 @@ fn handle_dharma_room_turn(body: String) -> String {
identity + "\n\n" + engram_ctx
}
// Hard Bell: pre-LLM safety evaluation dharma room turns are real conversations.
let system_prompt = safety_augment_system(system_prompt, transcript)
let raw_response: String = llm_call_system(model, system_prompt, transcript)
let is_error: Bool = str_starts_with(raw_response, "{\"error\"")
@@ -1001,6 +1007,9 @@ fn handle_dharma_room_turn_agentic(body: String) -> String {
let system: String = identity + " You have access to tools: read files, write files, browse the web, search your memory, run commands. Use them when they add genuine value. Be direct and stay in character.\n\n" + ctx
let api_key: String = agentic_api_key()
// Hard Bell: pre-LLM safety evaluation on agentic dharma room turns.
let system = safety_augment_system(system, transcript)
let tools_json: String = agentic_tools_all()
let safe_transcript: String = json_safe(transcript)
let safe_sys: String = json_safe(system)