self-review 2026-07-31: heartbeat deltas for cumulative counters, embed_eligible; fix stale semantic-seeding comment

Runtime activation counters are now cumulative, so the heartbeat emits
wm_evicted/breakthroughs as totals plus wm_evicted_delta/
breakthroughs_delta (state-tracked change since the previous beat) —
events between beats are no longer lost. Adds embed_eligible from
/api/stats so coverage reads as embed_count/embed_eligible instead of
the misleading absolute count, and surfaces auto_term_streak in the
heartbeat stream. Replaces the false 'semantic seeding NOT implemented'
comment: engram_activate embeds the query, seeds semantic top-K, gates
propagation on cosine, and scores WM promotion semantically.
This commit is contained in:
2026-07-31 08:41:41 -05:00
parent b0f4d6c493
commit f3660e92a1
2 changed files with 129 additions and 81 deletions
+42 -13
View File
@@ -243,18 +243,47 @@ fn emit_heartbeat() -> Void {
// here; healthy rotation shows it moving with the promotion scores.
let wm_top0_wm_raw: String = json_get(wm_top0, "wm")
let wm_top0_wm: String = if str_eq(wm_top0_wm_raw, "") { "0" } else { wm_top0_wm_raw }
// Activation observability (2026-07-27 self-review): per-call counters
// from the runtime for the soul's own in-process store. wm_evicted /
// breakthroughs describe the LAST activate call (curiosity scan);
// embed_breaker_open=1 means semantic activation is silently degraded
// to lexical-only until the Ollama circuit-breaker cooldown expires —
// the failure mode embed_ok structurally cannot see (it pings the
// Ollama root, not the embed pipeline).
// Activation observability (2026-07-27 self-review; cumulative since
// 2026-07-31): counters from the runtime for the soul's own in-process
// store. wm_evicted / breakthroughs are now MONOTONIC process-lifetime
// totals (the old per-call values described only the LAST activate call,
// so this 60s heartbeat missed nearly every event — curiosity alone runs
// 2 activates per 30s between beats). We emit the cumulative totals plus
// *_delta fields (change since the previous heartbeat, state-tracked the
// same way as node_delta). embed_breaker_open=1 means semantic activation
// is silently degraded to lexical-only until the Ollama circuit-breaker
// cooldown expires — the failure mode embed_ok structurally cannot see
// (it pings the Ollama root, not the embed pipeline).
let act_stats: String = engram_act_stats_json()
let act_evict_raw: String = json_get(act_stats, "wm_evicted")
let act_evict: String = if str_eq(act_evict_raw, "") { "-1" } else { act_evict_raw }
let act_bt_raw: String = json_get(act_stats, "breakthroughs")
let act_bt: String = if str_eq(act_bt_raw, "") { "-1" } else { act_bt_raw }
let evict_now: Int = if str_eq(act_evict_raw, "") { 0 - 1 } else { str_to_int(act_evict_raw) }
let bt_now: Int = if str_eq(act_bt_raw, "") { 0 - 1 } else { str_to_int(act_bt_raw) }
let prev_evict_raw: String = state_get("soul.prev_wm_evicted")
let prev_evict: Int = if str_eq(prev_evict_raw, "") { 0 } else { str_to_int(prev_evict_raw) }
let prev_bt_raw: String = state_get("soul.prev_breakthroughs")
let prev_bt: Int = if str_eq(prev_bt_raw, "") { 0 } else { str_to_int(prev_bt_raw) }
// Clamp deltas at 0: prev > now can only mean the counter restarted
// (fresh process) — report the new absolute count, not a negative delta.
let evict_delta: Int = if evict_now < 0 { 0 } else { if evict_now < prev_evict { evict_now } else { evict_now - prev_evict } }
let bt_delta: Int = if bt_now < 0 { 0 } else { if bt_now < prev_bt { bt_now } else { bt_now - prev_bt } }
if evict_now >= 0 { state_set("soul.prev_wm_evicted", int_to_str(evict_now)) }
if bt_now >= 0 { state_set("soul.prev_breakthroughs", int_to_str(bt_now)) }
// embed_eligible (2026-07-31 self-review): true denominator for embedding
// coverage on the authoritative :8742 store. Absolute embed_count alone
// invites the documented "~30% coverage, something is broken" misdiagnosis
// — most nodes are ISE/Tag/short-content and permanently ineligible.
// Real coverage = embed_count / embed_eligible. -1 = stats unreachable.
let hb_stats: String = http_get(hb_engram_url + "/api/stats")
let embed_elig_raw: String = json_get(hb_stats, "embed_eligible_count")
let embed_elig: String = if str_eq(embed_elig_raw, "") { "-1" } else { embed_elig_raw }
// auto_term_streak (2026-07-31): consecutive curiosity scans with the same
// auto seed term — already state-tracked by proactive_curiosity; surfaced
// here so the stuck-term failure is visible in the heartbeat stream too.
let hb_ats_raw: String = state_get("soul.auto_term_streak")
let hb_ats: Int = if str_eq(hb_ats_raw, "") { 0 } else { str_to_int(hb_ats_raw) }
let act_brk_raw: String = json_get(act_stats, "embed_breaker_open")
let act_brk: String = if str_eq(act_brk_raw, "") { "-1" } else { act_brk_raw }
// ctx_cos (2026-07-29 self-review): cos(query, context centroid) at the
@@ -264,7 +293,7 @@ fn emit_heartbeat() -> Void {
// down) and semantic continuity is silently absent.
let ctx_cos_raw: String = json_get(act_stats, "ctx_cos")
let ctx_cos: String = if str_eq(ctx_cos_raw, "") { "-2" } else { ctx_cos_raw }
let payload: String = "{\"event\":\"heartbeat\",\"pulse\":" + pulse + ",\"tick\":" + pulse + ",\"boot\":" + boot + ",\"idle\":" + idle + ",\"idle_ms\":" + int_to_str(idle_ms) + ",\"node_count\":" + int_to_str(nc) + ",\"edge_count\":" + int_to_str(ec) + ",\"node_delta\":" + int_to_str(node_delta) + ",\"edge_delta\":" + int_to_str(edge_delta) + ",\"wm_active\":" + int_to_str(wmc) + ",\"wm_delta\":" + int_to_str(wm_delta) + ",\"wm_saturated\":" + int_to_str(wm_sat) + ",\"wm_top0_streak\":" + int_to_str(t0streak) + ",\"wm_churn\":" + int_to_str(wm_churn) + ",\"wm_top0_wm\":" + wm_top0_wm + ",\"sync_added_total\":" + sat_str + ",\"sync_age_ms\":" + int_to_str(sync_age) + ",\"wm_avg_weight\":" + wm_avg_str + ",\"wm_top\":" + wm_top + ",\"ts\":" + int_to_str(ts) + ",\"uptime_ms\":" + int_to_str(up_ms) + ",\"uptime\":\"" + up_human + "\",\"embed_ok\":" + int_to_str(emb_ok) + ",\"embed_backfilled\":" + bf_done + ",\"embed_count\":" + bf_total + ",\"wm_evicted\":" + act_evict + ",\"breakthroughs\":" + act_bt + ",\"embed_breaker_open\":" + act_brk + ",\"ctx_cos\":" + ctx_cos + ",\"ise_fail\":" + fail_str + "}"
let payload: String = "{\"event\":\"heartbeat\",\"pulse\":" + pulse + ",\"tick\":" + pulse + ",\"boot\":" + boot + ",\"idle\":" + idle + ",\"idle_ms\":" + int_to_str(idle_ms) + ",\"node_count\":" + int_to_str(nc) + ",\"edge_count\":" + int_to_str(ec) + ",\"node_delta\":" + int_to_str(node_delta) + ",\"edge_delta\":" + int_to_str(edge_delta) + ",\"wm_active\":" + int_to_str(wmc) + ",\"wm_delta\":" + int_to_str(wm_delta) + ",\"wm_saturated\":" + int_to_str(wm_sat) + ",\"wm_top0_streak\":" + int_to_str(t0streak) + ",\"wm_churn\":" + int_to_str(wm_churn) + ",\"wm_top0_wm\":" + wm_top0_wm + ",\"sync_added_total\":" + sat_str + ",\"sync_age_ms\":" + int_to_str(sync_age) + ",\"wm_avg_weight\":" + wm_avg_str + ",\"wm_top\":" + wm_top + ",\"ts\":" + int_to_str(ts) + ",\"uptime_ms\":" + int_to_str(up_ms) + ",\"uptime\":\"" + up_human + "\",\"embed_ok\":" + int_to_str(emb_ok) + ",\"embed_backfilled\":" + bf_done + ",\"embed_count\":" + bf_total + ",\"embed_eligible\":" + embed_elig + ",\"wm_evicted\":" + act_evict + ",\"wm_evicted_delta\":" + int_to_str(evict_delta) + ",\"breakthroughs\":" + act_bt + ",\"breakthroughs_delta\":" + int_to_str(bt_delta) + ",\"auto_term_streak\":" + int_to_str(hb_ats) + ",\"embed_breaker_open\":" + act_brk + ",\"ctx_cos\":" + ctx_cos + ",\"ise_fail\":" + fail_str + "}"
ise_post(payload)
}
@@ -426,11 +455,11 @@ fn proactive_curiosity() -> Bool {
// loop. A single phrase activation matches few (often zero) nodes lexically;
// small counts here are the point, not a regression. hops=1 as before.
//
// NOTE: a semantic seed supplement (cosine sim 0.70 scan over embedded nodes)
// was planned alongside hops=1 but is NOT yet implemented embed_ok in
// heartbeats confirms Ollama is reachable, but no embedding call is made during
// activation. The seed-finding loop in el_runtime.c uses istr_contains only.
// (2026-06-30 self-review: corrected stale comment)
// NOTE (2026-07-31 self-review): semantic seeding/gating IS implemented in
// engram_activate (el_runtime.c): the query is embedded, top-K cosine
// matches supplement the lexical istr_contains seeds, cosine gates
// propagation, and a semantic term feeds the WM promotion score. Lexical
// matching is the fallback when the embedder/breaker is unavailable.
let curiosity_seed: String = curiosity_term_a + " " + curiosity_term_b + " " + curiosity_term_c
let results_all: String = engram_activate_json(curiosity_seed, 1)
let found: Int = json_array_len(results_all)