refactor(server): canonicalize service API (#31049)

2026-06-06 23:27:28 -04:00
parent 53ff1b57c9
commit fe0c4f8c74
388 changed files with 7103 additions and 4092 deletions
@@ -1,56 +1,8 @@
 import { describe, expect, test } from "bun:test"
 import { NamedError } from "@opencode-ai/core/util/error"
-import { errorData, errorFormat, errorMessage } from "../../src/util/error"
 import { MessageError } from "../../src/session/message-error"

 describe("util.error", () => {
-  test("formats native Error instances", () => {
-    const err = new Error("boom")
-    expect(errorMessage(err)).toBe("boom")
-    expect(errorFormat(err)).toContain("boom")
-
-    const data = errorData(err)
-    expect(data.type).toBe("Error")
-    expect(data.message).toBe("boom")
-    expect(String(data.formatted)).toContain("boom")
-  })
-
-  test("extracts message from record-like values", () => {
-    const err = { message: "bad input", code: "E_BAD" }
-    expect(errorMessage(err)).toBe("bad input")
-
-    const data = errorData(err)
-    expect(data.message).toBe("bad input")
-    expect(data.code).toBe("E_BAD")
-  })
-
-  test("never returns bare {} for opaque object errors", () => {
-    // Plain empty object — what the SDK threw before we wrapped it.
-    expect(errorFormat({})).not.toBe("{}")
-    expect(errorFormat({})).toContain("no message")
-
-    // Object with only non-enumerable own properties (JSON.stringify drops them).
-    class OpaqueError {}
-    const opaque = new OpaqueError()
-    Object.defineProperty(opaque, "secret", { value: "hidden", enumerable: false })
-    expect(errorFormat(opaque)).not.toBe("{}")
-    expect(errorFormat(opaque)).toContain("OpaqueError")
-  })
-
-  test("handles opaque throwables with custom toString", () => {
-    const err = {
-      toString() {
-        return "ResolveMessage: Cannot resolve module"
-      },
-    }
-
-    expect(errorMessage(err)).toBe("ResolveMessage: Cannot resolve module")
-
-    const data = errorData(err)
-    expect(data.message).toBe("ResolveMessage: Cannot resolve module")
-    expect(String(data.formatted)).toContain("ResolveMessage")
-  })
-
  test("schema-backed named errors are real NamedError instances", () => {
    const error = new MessageError.AuthError({ providerID: "anthropic", message: "boom" })

@@ -1,59 +0,0 @@
-import { describe, expect, test } from "bun:test"
-import { formatDuration } from "../../src/util/format"
-
-describe("util.format", () => {
-  describe("formatDuration", () => {
-    test("returns empty string for zero or negative values", () => {
-      expect(formatDuration(0)).toBe("")
-      expect(formatDuration(-1)).toBe("")
-      expect(formatDuration(-100)).toBe("")
-    })
-
-    test("formats seconds under a minute", () => {
-      expect(formatDuration(1)).toBe("1s")
-      expect(formatDuration(30)).toBe("30s")
-      expect(formatDuration(59)).toBe("59s")
-    })
-
-    test("formats minutes under an hour", () => {
-      expect(formatDuration(60)).toBe("1m")
-      expect(formatDuration(61)).toBe("1m 1s")
-      expect(formatDuration(90)).toBe("1m 30s")
-      expect(formatDuration(120)).toBe("2m")
-      expect(formatDuration(330)).toBe("5m 30s")
-      expect(formatDuration(3599)).toBe("59m 59s")
-    })
-
-    test("formats hours under a day", () => {
-      expect(formatDuration(3600)).toBe("1h")
-      expect(formatDuration(3660)).toBe("1h 1m")
-      expect(formatDuration(7200)).toBe("2h")
-      expect(formatDuration(8100)).toBe("2h 15m")
-      expect(formatDuration(86399)).toBe("23h 59m")
-    })
-
-    test("formats days under a week", () => {
-      expect(formatDuration(86400)).toBe("~1 day")
-      expect(formatDuration(172800)).toBe("~2 days")
-      expect(formatDuration(259200)).toBe("~3 days")
-      expect(formatDuration(604799)).toBe("~6 days")
-    })
-
-    test("formats weeks", () => {
-      expect(formatDuration(604800)).toBe("~1 week")
-      expect(formatDuration(1209600)).toBe("~2 weeks")
-      expect(formatDuration(1609200)).toBe("~2 weeks")
-    })
-
-    test("handles boundary values correctly", () => {
-      expect(formatDuration(59)).toBe("59s")
-      expect(formatDuration(60)).toBe("1m")
-      expect(formatDuration(3599)).toBe("59m 59s")
-      expect(formatDuration(3600)).toBe("1h")
-      expect(formatDuration(86399)).toBe("23h 59m")
-      expect(formatDuration(86400)).toBe("~1 day")
-      expect(formatDuration(604799)).toBe("~6 days")
-      expect(formatDuration(604800)).toBe("~1 week")
-    })
-  })
-})