neuron-technologies/neuron
3
0
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(reliability): engram-write #38

Closed
will.anderson wants to merge 0 commits from improve/reliability-engram-write into main
pull from: improve/reliability-engram-write
merge into: :main
Conversation 0 Commits - Files Changed -
will.anderson commented 2026-06-22 16:51:31 +00:00
Owner
Copy Link
Copy Source

Reliability fixes from automated audit.

Guards all fire-and-forget engram_node_full and engram_save calls with return-value checks and println logging. Adds api_persisted() read-back guard to handle_api_log_state_event and handle_api_tune_config. TODO comments added for non-atomic write patterns (#12, #13) and missing circuit breaker (#14).

Reliability fixes from automated audit. Guards all fire-and-forget engram_node_full and engram_save calls with return-value checks and println logging. Adds api_persisted() read-back guard to handle_api_log_state_event and handle_api_tune_config. TODO comments added for non-atomic write patterns (#12, #13) and missing circuit breaker (#14).
will.anderson added 1 commit 2026-06-22 16:51:34 +00:00
fix(reliability): engram-write — guard all fire-and-forget writes
Neuron Soul CI / build (pull_request) Has been cancelled
Details
494d973a3b 
Every engram_node_full call that dropped its return value now binds it
and emits a println on empty string. engram_save calls in consolidate,
heartbeat, and dharma-room-turn are checked for failure. The two API
handlers (log_state_event, tune_config) that skipped api_persisted()
now match the read-back-after-write contract used everywhere else in
neuron-api.el.

Files changed:
- chat.el: conv_history_persist, handle_dharma_room_turn, auto_persist
- soul.el: emit_session_start_event, seed_persona_from_env HTTP check
- memory.el: mem_save, mem_boot_count_inc
- neuron-api.el: handle_api_log_state_event, handle_api_tune_config,
  handle_api_consolidate (engram_save + session summary write)
- awareness.el: ise_post local-engram fallback path

TODO comments added for non-atomic patterns (issues #12, #13) and
the missing circuit breaker (#14) — these require new primitives.
will.anderson added 1 commit 2026-06-22 17:21:53 +00:00
fix(reliability): replace undefined session_exists with session_get check
Neuron Soul CI / build (pull_request) Failing after 13m25s
Details
392d2416ec
will.anderson closed this pull request 2026-06-22 17:55:30 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
BETA-CRITICAL
On the beta critical path — must resolve before ship
 blocks-public-beta
Must be fixed before any public beta
 HELD
Blocked pending an external decision (counsel / dual sign-off)
 ORTHOGONAL
Parallel workstream (testing/hardening) — safe to assign off critical path
 P0
Drop-everything severity
 POST-BETA
Important but not blocking the beta ship
 security
Security vulnerability
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andre.almeida (Andre Almeida) tim.lingo (Tim Lingo) will.anderson (Will Anderson)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: neuron-technologies/neuron#38
Delete Branch "improve/reliability-engram-write"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?