neuron-technologies/neuron
2
0
Fork 0
Code Issues 11 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

feat(soul): MCP connectors proxy + safety module + seeding ratio guard #63

Open
tim.lingo wants to merge 0 commits from feat/connectors-soul into main
pull from: feat/connectors-soul
merge into: :main
Conversation 0 Commits - Files Changed -
tim.lingo commented 2026-06-30 18:53:06 +00:00
Member
Copy Link
Copy Source

Local-only branch surfaced for review (was never pushed). 3 new commits, clean merge into main:

  • feat(soul): MCP connectors — /api/connectors proxy + per-connector auto-approve
  • feat(soul): add safety module, expand connectors API, memory-recall bug notes
  • fix(soul): ratio guard against genesis seeding over a populated engram (engram-corruption guard)

Verified all three are not already in main (patch-id check). Mergeable clean. Opening per Tim's request to get the local soul work through review.

🤖 Generated with Claude Code

Local-only branch surfaced for review (was never pushed). 3 new commits, clean merge into main: - feat(soul): MCP connectors — /api/connectors proxy + per-connector auto-approve - feat(soul): add safety module, expand connectors API, memory-recall bug notes - fix(soul): ratio guard against genesis seeding over a populated engram (engram-corruption guard) Verified all three are not already in main (patch-id check). Mergeable clean. Opening per Tim's request to get the local soul work through review. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
tim.lingo added 3 commits 2026-06-30 18:53:09 +00:00
feat(soul): MCP connectors — /api/connectors proxy + per-connector auto-approve 6c57d4fe1b 
Adds the soul side of the connectors feature (spec: docs/research/
mcp-connectors-adoption-spec.md). The soul thin-proxies the neuron-connectd
bridge on 127.0.0.1:7771 so the UI talks to one origin and never reaches the
bridge directly.

routes.el:
- handle_connectors + connectd_get/connectd_post helpers (POST bodies go via
  a temp file + curl -d @file, so model/UI input can't reach the shell).
- GET /api/connectors and POST /api/connectors/{add,toggle,auto-approve,
  remove,secret,oauth/start} registered in both GET and POST routers.

chat.el:
- tool_auto_approved(): an mcp__* tool skips the approval card only when its
  server is explicitly opted in (off by default; built-in tools unaffected;
  bridge down -> false). Wired into the agentic approval gate so an
  auto-approved connector tool flows straight to execution.

Regenerated dist/chat.c and dist/routes.c. Verified live on :7770: real chat,
recall, and /api/connectors all work after promotion.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(soul): add safety module, expand connectors API, memory-recall bug notes 3bb17a5296 
- safety.el/.elh: new safety module
- neuron-api.el, routes.el, soul.el, chat.el: connectors API expansion
- regenerated dist/ C artifacts
- MEMORY_RECALL_BUG.md: investigation notes

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(soul): ratio guard against genesis seeding over a populated engram
Neuron Soul CI / build (pull_request) Successful in 5m44s
Details
bcdadb7323 
Genesis boot previously seeded a fresh identity and saved it over snapshot.json
whenever the in-memory graph looked empty. Replace the fixed node-count threshold
with a ratio guard: refuse to seed when the on-disk snapshot is large
(>200KB) but the loaded graph is sparse (< disk/16000 nodes).

KNOWN LIMITATION: this gates only the seed/pre-serve-save path. The deeper cause
is a non-atomic engram_save (fopen wb truncates to 0 before writing 47MB), which
creates a window where a concurrent load reads an empty file -> genesis -> and if
guard_disk is read in that same window the guard passes. The real fix is an
atomic engram_save (temp + fsync + rename) in el_runtime.c, tracked separately.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
All checks were successful
Neuron Soul CI / build (pull_request) Successful in 5m44s
Details
This branch is already included in the target branch. There is nothing to merge.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/connectors-soul:feat/connectors-soul
git checkout feat/connectors-soul
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
tim.lingo (Tim Lingo) will.anderson (Will Anderson)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: neuron-technologies/neuron#63
Delete Branch "feat/connectors-soul"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?