neuron-technologies/neuron-web
2
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix implicit declaration of page_close on Linux #20

Merged
will.anderson merged 1 commits from fix/stage-source-check into dev 2026-05-09 22:54:06 +00:00
Conversation 0 Commits 1 Files Changed 2
+7 -3
will.anderson commented 2026-05-09 22:50:12 +00:00
Owner
Copy Link
Copy Source

ci-base elb doesn't emit forward declarations for extern fns imported across modules. page_close (an extern fn) is called by main.el, terms.el, and enterprise_terms.el — the compiler saw an implicit int return, truncating the 64-bit pointer on call, causing a startup segfault on Linux.

Fix: rename C function to _page_close_impl, wrap with a native El fn page_close() { return _page_close_impl() } — native El fns get proper forward declarations generated by elb.

ci-base elb doesn't emit forward declarations for extern fns imported across modules. page_close (an extern fn) is called by main.el, terms.el, and enterprise_terms.el — the compiler saw an implicit int return, truncating the 64-bit pointer on call, causing a startup segfault on Linux. Fix: rename C function to _page_close_impl, wrap with a native El fn page_close() { return _page_close_impl() } — native El fns get proper forward declarations generated by elb.
will.anderson added 1 commit 2026-05-09 22:50:14 +00:00
Fix implicit declaration of page_close on Linux: wrap extern as native El fn
Dev — Build & local smoke test / build-smoke (pull_request) Successful in 3m25s
Details
9892d89c01
will.anderson merged commit 0abef440fa into dev 2026-05-09 22:54:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
tim.lingo (Tim Lingo) will.anderson (Will Anderson)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: neuron-technologies/neuron-web#20
Delete Branch "fix/stage-source-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?