Compare commits

..

4 Commits

Author SHA1 Message Date
will.anderson ca29e7ca35 Merge pull request 'fix(ci): link soul.c only — fixes capability #error breaking every build' (#26) from fix/ci-soul-build-single-file into main
Neuron Soul CI / build (push) Failing after 9m27s
Deploy Soul to GKE / deploy (push) Failing after 10m3s
fix(ci): link soul.c only — fixes capability #error breaking every build
2026-06-18 16:29:05 +00:00
will.anderson 6576dddca2 Merge pull request 'fix(chat): remove duplicate web_search tool crashing all agentic requests' (#22) from fix/agentic-tools-duplicate-web-search into main
Deploy Soul to GKE / deploy (push) Failing after 8m40s
Neuron Soul CI / build (push) Failing after 10m21s
fix(chat): remove duplicate web_search tool crashing all agentic requests
2026-06-18 16:28:41 +00:00
will.anderson ce3c3873c5 fix(ci): link soul.c only — drop multi-module cc that triggers capability #error
Neuron Soul CI / build (pull_request) Failing after 7m44s
elb generates a dist/soul.c with all El modules inlined. Linking
dist/soul.c alone is sufficient and is exactly what the local mac
build does. Including other dist/*.c files causes two failures:
  1. dist/chat.c has a capability-violation #error that fires when the
     file is compiled as a utility module (outside the cgi entrypoint).
  2. --allow-multiple-definition masked other issues silently.

Drop OTHER_C, drop --allow-multiple-definition, drop the now-unused
elp-c-decls.h generation step. The cc command now matches the proven
local build exactly.
2026-06-18 11:27:57 -05:00
will.anderson 53fb75353f fix(chat): remove duplicate web_search tool in agentic_tools_all
Neuron Soul CI / build (pull_request) Failing after 5m24s
agentic_tools_literal() already contains a custom web_search tool.
agentic_tools_with_web() adds the Anthropic server-side web_search_20250305
tool (also named web_search). Combining them caused Anthropic to reject
every agentic request with 'Tool names must be unique.'

agentic_tools_all() now calls agentic_tools_literal() directly. Connector
tools splice in as before. The web_search-only variant (agentic_tools_with_web)
is unchanged for callers that specifically want native search without connectors.
2026-06-17 14:11:50 -05:00
3 changed files with 16 additions and 49 deletions
+10 -25
View File
@@ -91,44 +91,29 @@ jobs:
echo "El SDK ready"
/opt/el/dist/platform/elc --version || true
- name: Generate ELP master declarations header
run: |
{
printf '/* Auto-generated C forward declarations for ELP cross-module calls */\n'
printf '#pragma once\n'
printf '#include "el_runtime.h"\n'
printf '\n'
grep -h -E '^(el_val_t|void|int|char\*|const char\*)[[:space:]]+[a-zA-Z_][a-zA-Z0-9_]*[[:space:]]*\(' dist/*.c 2>/dev/null \
| grep ';$' | sort -u
} > dist/elp-c-decls.h
echo "Generated elp-c-decls.h with $(grep -c ';' dist/elp-c-decls.h 2>/dev/null || echo 0) declarations"
- name: Build neuron soul binary
run: |
ELB=/opt/el/dist/bin/elb
ELC=/opt/el/dist/platform/elc
RUNTIME=/opt/el/runtime
# Compile all El modules to C.
# This step will fail at link on Linux: the El compiler inlines imported
# modules into each module's .c file, producing duplicate strong symbol
# definitions. GNU ld rejects these; macOS ld accepts them silently.
# We capture the link failure and re-link manually below.
# Compile all El modules to C via elb.
# elb fails at link on Linux (GNU ld rejects duplicate strong symbols that
# macOS ld accepts silently) — that's expected and captured with || true.
# The important output is dist/soul.c: the El compiler inlines all imported
# modules into the entry-point file, so soul.c is a self-contained
# translation unit. We never link the other dist/*.c files — they contain
# the same symbols inlined again, plus capability-violation #error guards
# that fire when compiled outside the cgi entrypoint.
$ELB --elc=$ELC --runtime=$RUNTIME/el_runtime.c || true
# Re-link with soul.c listed first so its real main() (from the cgi block)
# wins over the stub main()s generated in every other module.
# --allow-multiple-definition tells GNU ld to pick the first definition
# for each duplicate symbol — safe here because all duplicates are identical
# (same El source compiled independently into multiple .c files).
# Link only soul.c + the runtime. No --allow-multiple-definition needed.
mkdir -p dist
OTHER_C=$(ls dist/*.c | grep -v '/soul\.c$' | sort | tr '\n' ' ')
cc -O2 -DHAVE_CURL \
-I$RUNTIME \
dist/soul.c $OTHER_C \
dist/soul.c \
$RUNTIME/el_runtime.c \
-lssl -lcrypto -lcurl -lpthread -lm \
-Wl,--allow-multiple-definition \
-o dist/neuron
ls -lh dist/neuron
+6 -3
View File
@@ -317,10 +317,13 @@ fn connector_tools_json() -> String {
return arr
}
// Built-in tools + native web_search + every connector tool, as one tools array.
// Splices connector tools in before the closing bracket of the base array.
// Built-in tools + every connector tool, as one tools array.
// Uses agentic_tools_literal (not agentic_tools_with_web) to avoid a duplicate
// "web_search" name the literal already includes a custom web_search handler,
// and adding the Anthropic server-side web_search_20250305 (same name) causes
// Anthropic to reject with "Tool names must be unique."
fn agentic_tools_all() -> String {
let base: String = agentic_tools_with_web()
let base: String = agentic_tools_literal()
let conn: String = connector_tools_json()
let conn_inner: String = str_slice(conn, 1, str_len(conn) - 1)
if str_eq(conn_inner, "") {
-21
View File
@@ -95,24 +95,6 @@ fn init_soul_edges() -> Void {
engram_connect(val_hope, val_trust, el_from_float(0.7), "co-value")
}
// ensure_self_canonical_bridge link the public self anchor (the graph API's
// traversal_root, kn-efeb4a5b, which carries only incidental tag edges) to the
// curated self node (015644f5, where the real identity / value / co-value edges
// live). Without this, public self-traversal (name=self / neuron) reaches tags
// instead of the curated identity. Idempotent: connects only if the edge is
// missing, so it is safe to run every boot including on an already-populated
// graph where init_soul_edges() is skipped by the <100-edge gate.
fn ensure_self_canonical_bridge() -> Void {
let pub_self: String = "kn-efeb4a5b-5aff-4759-8a97-7233099be6ee"
let curated_self: String = "015644f5-8194-4af0-800d-dd4a0cd71396"
let nbrs: String = engram_neighbors_json(pub_self, 1, "out")
if !str_contains(nbrs, curated_self) {
engram_connect(pub_self, curated_self, el_from_float(0.95), "canonical-self")
engram_connect(curated_self, pub_self, el_from_float(0.95), "canonical-self")
println("[soul] canonical-self bridge built: kn-efeb4a5b <-> 015644f5")
}
}
// load_identity_context pull key identity nodes from engram into working state.
// Called at boot after engram_load. These nodes contain values, intellectual-dna,
// memory-philosophy the graph-stored self that chat.el can include in prompts.
@@ -416,9 +398,6 @@ if is_genesis && safe_to_seed {
} else {
println("[soul] edges already present (" + int_to_str(edge_count_now) + ") - skipping init")
}
// Canonical-self bridge is idempotent run it regardless of edge count so an
// already-populated graph still gets the public->curated self link.
ensure_self_canonical_bridge()
// Genesis saves to its local snapshot file (it manages its own Engram).
state_set("soul_snapshot_path", snapshot)
engram_save(snapshot)