neuron-technologies/neuron
3
0
Fork 0
Code Issues 44 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

chore(repo): suppress generated dist/ artifacts in PR diffs #16

Closed
tim.lingo wants to merge 0 commits from chore/suppress-generated-diffs into main
pull from: chore/suppress-generated-diffs
merge into: :main
Conversation 2 Commits - Files Changed -
tim.lingo commented 2026-06-14 20:37:21 +00:00
Member
Copy Link
Copy Source

Makes every PR reviewable again. dist/.c + .elh are elc transpiler output; one soul change regenerates ~57k lines of dist/neuron.c + dist/soul.c that bury the real source diff (why PRs #5 and #9 are 70k-line walls). Marking dist/* -diff + linguist-generated suppresses them in diffs and Gitea's PR view. They stay TRACKED so CI's header-gen (greps dist/.c) is unchanged. Proven: a dist/soul.c change now renders 'Binary files differ', not 57k lines.

Makes every PR reviewable again. dist/*.c + *.elh are elc transpiler output; one soul change regenerates ~57k lines of dist/neuron.c + dist/soul.c that bury the real source diff (why PRs #5 and #9 are 70k-line walls). Marking dist/** -diff + linguist-generated suppresses them in diffs and Gitea's PR view. They stay TRACKED so CI's header-gen (greps dist/*.c) is unchanged. Proven: a dist/soul.c change now renders 'Binary files differ', not 57k lines.
tim.lingo added 1 commit 2026-06-14 20:37:22 +00:00
chore(repo): suppress generated dist/ artifacts in diffs
Neuron Soul CI / build (pull_request) Successful in 4m18s
Details
8f84e12218 
dist/*.c and *.elh are elc transpiler output. CI's header-gen step still
greps dist/*.c, so they stay tracked, but a single soul change regenerates
~57k lines of dist/neuron.c + dist/soul.c that bury the real source diff and
poison both human and agent PR review. Mark them -diff + linguist-generated so
PRs show only the real changes. Build pipeline unchanged.
tim.lingo commented 2026-06-14 21:05:36 +00:00
Author
Member
Copy Link
Copy Source

START HERE — merge this first.

CI-green, no conflicts. Marks generated dist/ files as -diff so every OTHER open PR stops rendering as a 70k-line wall and shows only its real source change. Build untouched (CI still greps dist/*.c; files stay tracked).

Sequence once this lands:

  1. #16 (this) — unblocks readable diffs on everything below
  2. #1 — engram write-corruption fix (135 lines) — small, real bug
  3. #3 — Claude-as-Neuron CLI tooling (767, all new files) — additive
  4. #14 — connectors /api proxy (617) — medium
  5. reconcile #9 <-> #5 — they OVERLAP ~80%; pick canonical (likely #9), merge one, rebase/close the other. The only deep-judgment item.

Each PR has its own inline handoff comment. 4 of 5 are small/low-risk and move fast once this merges.

START HERE — merge this first. CI-green, no conflicts. Marks generated dist/ files as -diff so every OTHER open PR stops rendering as a 70k-line wall and shows only its real source change. Build untouched (CI still greps dist/*.c; files stay tracked). Sequence once this lands: 1. #16 (this) — unblocks readable diffs on everything below 2. #1 — engram write-corruption fix (135 lines) — small, real bug 3. #3 — Claude-as-Neuron CLI tooling (767, all new files) — additive 4. #14 — connectors /api proxy (617) — medium 5. reconcile #9 <-> #5 — they OVERLAP ~80%; pick canonical (likely #9), merge one, rebase/close the other. The only deep-judgment item. Each PR has its own inline handoff comment. 4 of 5 are small/low-risk and move fast once this merges.
tim.lingo commented 2026-06-14 21:26:54 +00:00
Author
Member
Copy Link
Copy Source

@will.anderson — start here when you (or your Neuron) pick the queue back up.

#16 is the keystone: merge it first (it's green, no conflicts). It marks the generated dist/*.c as -diff, so every other open PR stops showing up as a ~70k-line wall and renders only its real source change — that's almost certainly what was making these unreviewable.

Order after #16:

  • #1 — engram write-corruption fix (135 lines, real bug)
  • #3 — CLI tooling (767, all new files, additive)
  • #14 — connectors /api proxy (617)
  • then #9 ↔ #5: these overlap ~80% (same awareness.el / mcp-wrapper / neuron-api changes). They're the same work in two diffs — pick the canonical one (probably your #9), merge it, rebase/close the other. That's the only one that needs a real call.

Each PR has an inline handoff comment (what / why / risk / verify). Teed up so it should move fast. — Tim

@will.anderson — start here when you (or your Neuron) pick the queue back up. #16 is the keystone: merge it first (it's green, no conflicts). It marks the generated `dist/*.c` as `-diff`, so every other open PR stops showing up as a ~70k-line wall and renders only its real source change — that's almost certainly what was making these unreviewable. Order after #16: - #1 — engram write-corruption fix (135 lines, real bug) - #3 — CLI tooling (767, all new files, additive) - #14 — connectors /api proxy (617) - then #9 ↔ #5: these overlap ~80% (same awareness.el / mcp-wrapper / neuron-api changes). They're the same work in two diffs — pick the canonical one (probably your #9), merge it, rebase/close the other. That's the only one that needs a real call. Each PR has an inline handoff comment (what / why / risk / verify). Teed up so it should move fast. — Tim
will.anderson closed this pull request 2026-06-15 16:38:03 +00:00
will.anderson deleted branch chore/suppress-generated-diffs 2026-06-15 16:38:07 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
BETA-CRITICAL
On the beta critical path — must resolve before ship
 blocks-public-beta
Must be fixed before any public beta
 HELD
Blocked pending an external decision (counsel / dual sign-off)
 ORTHOGONAL
Parallel workstream (testing/hardening) — safe to assign off critical path
 P0
Drop-everything severity
 POST-BETA
Important but not blocking the beta ship
 security
Security vulnerability
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andre.almeida (Andre Almeida) tim.lingo (Tim Lingo) will.anderson (Will Anderson)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: neuron-technologies/neuron#16
Delete Branch "chore/suppress-generated-diffs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?