fix(routes): remove duplicate GET /api/sessions shadowing session_list() #17

Merged

will.anderson merged 3 commits from fix/sessions-route-dedup into main

2026-06-17 18:05:26 +00:00

Author	SHA1	Message	Date
will.anderson	b1fdd14ed5	fix(sessions): invalidate session_index cache in session_delete Neuron Soul CI / build (pull_request) Failing after 8m11s Details session_delete cleared the per-session state (session_hist_ and session_node_) but not the shared session_index cache. The next call to session_list() hit the fast path (state_get("session_index")) and returned the deleted session until the daemon restarted. session_update_patch already called state_set("session_index","") to force a re-fetch from Engram; session_delete now does the same. Add tests/test_sessions.el covering: - session_title_from_message (pure function, all edge cases) - session_make_content (JSON structure and required session:meta marker) - DELETE cache invalidation: session_index cleared, fast path disabled - PATCH cache invalidation: stale title/folder not returned via fast path - GET /api/sessions: session_list() fast path returns session_index (confirms removal of the stale route_sessions() engram stub)	2026-06-17 12:59:47 -05:00
will.anderson	26513d56b7	fix(chat): store bridge messages/tools as raw JSON to prevent double-escape corruption on agentic_resume bridge_save was wrapping messages and tools_json with json_safe() before storing them as string fields. Since both are already well-formed JSON arrays containing double quotes, json_safe added a second escape layer. agentic_resume then called json_get() which stripped only one layer, leaving the messages array corrupted before it was passed back into agentic_loop. Fix: store messages as messages_raw and tools_json as tools_raw as inline raw JSON values (unquoted), and read them back with json_get_raw. Backward compatibility: fall back to the old string-escaped fields if the raw fields are absent, so sessions saved before this fix can still be resumed. Also fixes write_file returning a pre-escaped literal instead of calling json_safe consistently with every other tool result.	2026-06-15 13:04:51 -05:00
will.anderson	c43d3e6ca8	fix(routes): remove duplicate GET /api/sessions that shadowed session_list() Neuron Soul CI / build (pull_request) Failing after 9m52s Details The first registration called route_sessions() which searched for a 'session-start' label that no longer exists, returning an empty array on every list request and making the sidebar appear empty after restart. The second registration (dead code) called the correct session_list(). Removes route_sessions() entirely and the stale first route block. Also wires up session_delete() and session_update_patch() — both existed in sessions.el but had no HTTP routes — via new DELETE and PATCH blocks.	2026-06-15 13:03:56 -05:00

Author

SHA1

Message

Date

will.anderson

b1fdd14ed5

fix(sessions): invalidate session_index cache in session_delete

Neuron Soul CI / build (pull_request) Failing after 8m11s

Details

session_delete cleared the per-session state (session_hist_ and
session_node_) but not the shared session_index cache. The next call
to session_list() hit the fast path (state_get("session_index")) and
returned the deleted session until the daemon restarted.

session_update_patch already called state_set("session_index","") to
force a re-fetch from Engram; session_delete now does the same.

Add tests/test_sessions.el covering:
- session_title_from_message (pure function, all edge cases)
- session_make_content (JSON structure and required session:meta marker)
- DELETE cache invalidation: session_index cleared, fast path disabled
- PATCH cache invalidation: stale title/folder not returned via fast path
- GET /api/sessions: session_list() fast path returns session_index
  (confirms removal of the stale route_sessions() engram stub)

2026-06-17 12:59:47 -05:00

will.anderson

26513d56b7

fix(chat): store bridge messages/tools as raw JSON to prevent double-escape corruption on agentic_resume

bridge_save was wrapping messages and tools_json with json_safe() before
storing them as string fields. Since both are already well-formed JSON arrays
containing double quotes, json_safe added a second escape layer. agentic_resume
then called json_get() which stripped only one layer, leaving the messages array
corrupted before it was passed back into agentic_loop.

Fix: store messages as messages_raw and tools_json as tools_raw as inline raw
JSON values (unquoted), and read them back with json_get_raw. Backward
compatibility: fall back to the old string-escaped fields if the raw fields are
absent, so sessions saved before this fix can still be resumed.

Also fixes write_file returning a pre-escaped literal instead of calling
json_safe consistently with every other tool result.

2026-06-15 13:04:51 -05:00

will.anderson

c43d3e6ca8

fix(routes): remove duplicate GET /api/sessions that shadowed session_list()

Neuron Soul CI / build (pull_request) Failing after 9m52s

Details

The first registration called route_sessions() which searched for a
'session-start' label that no longer exists, returning an empty array
on every list request and making the sidebar appear empty after restart.
The second registration (dead code) called the correct session_list().

Removes route_sessions() entirely and the stale first route block.
Also wires up session_delete() and session_update_patch() — both existed
in sessions.el but had no HTTP routes — via new DELETE and PATCH blocks.

2026-06-15 13:03:56 -05:00

fix(routes): remove duplicate GET /api/sessions shadowing session_list() #17

3 Commits