will.anderson
96d6bef0c2
Three fixes from code review on improve/recall-engram-scoring: 1. CRITICAL — relevance denominator /10000 → /100: parse_salience_100 already scales floats to 0-100 (e.g. "0.7" → 70), so the product of two such values must be divided by 100 to stay in 0-100 range. The /10000 divisor caused integer truncation to 0 for every real-world node (sal=0.7, imp=0.7 → 70*70/10000 = 0). engram_compile_ranked was returning empty string for all inputs, leaving the soul with zero memory context. 2. CRITICAL — missing closing brace for hard_bell if-block in handle_chat_agentic (line ~1050): the return statement was not followed by the closing `}`, making the entire non-bell code path dead code inside the branch. All agentic turns that were not a hard_bell would silently fall through the open block. 3. HIGH — threshold 15 → 10 in engram_compile_ranked: even after the /100 fix, threshold=15 was marginally too aggressive for low-salience nodes near the Working-tier recency floor. sal=0.5 imp=0.5 at floor scores 16 (just above 15), so the margin was only 1 point. Lowering to 10 gives comfortable headroom while still filtering genuine noise (sal=0.1 imp=0.1 → score ≤ 1).