Tim Lingo
de65991807
Teaches the OpenAI-format lane (Groq/OpenAI/Grok/Gemini/Ollama) to offer tools,
execute them, and loop — the capability that until now existed only on the
Anthropic wire. The tool-execution, consent, bridge and run-progress machinery is
reused unchanged; only the wire dialect is new.
Two pre-existing defects were found while proving it, and are fixed here because
both silently break chat:
1. PROVIDER WIRING NEVER CONNECTED. The launcher exports SOUL_LLM_PROVIDER /
SOUL_LLM_BASE_URL and puts the provider key in ANTHROPIC_API_KEY + SOUL_API_KEY;
the engine's provider fork read only NEURON_LLM_0_*, which nothing sets in a
customer build. So use_openai was ALWAYS false: every non-Anthropic user's turns
went to api.anthropic.com carrying, say, a Groq key, and came back
"llm unavailable". Proven side-by-side against the pinned round-9 brain
(sha256 15cf7d1b…): identical env, shipped brain = "llm unavailable" both chat
modes with ZERO calls to the configured endpoint; this build = a real answer,
with the probe logging POST /v1/chat/completions and Bearer <provider key>.
Fixed brain-side only (env fallbacks) — no app or launcher change needed.
2. TRUNCATION SPLITS UTF-8 CHARACTERS. The session preload cuts recalled memory at
fixed BYTE lengths (continuity snippet 350; session_preload_bullets per bullet).
A cut landing inside a multi-byte character leaves a dangling lead byte in the
SYSTEM PROMPT, making the whole request body invalid UTF-8 — providers reject it
and the user sees an unexplained failure. Captured from a real body: 18,710 bytes,
decode fails at 18,248 on 'e2', a box-drawing rule (U+2500 = E2 94 80) sliced in
half. Trigger is ordinary content — em dash, curly quote, accented name, emoji,
table border — and it gets MORE likely as memory grows. Shared code: this hit the
Anthropic wire too. Fixed with utf8_safe_slice() applied at BOTH cut sites.
WHAT IS IN THE PORT
- llm_base_url / llm_wire_format / agentic_api_key: fall back to the launcher's own
SOUL_LLM_* names; anthropic deliberately still returns "" so its native path is
untouched (endpoint configurability remains neuron#62).
- openai_tools_json(): Anthropic tool schema -> OpenAI function schema; entries with
no input_schema (Anthropic's server-side web_search) are skipped — they cannot
execute on this wire.
- agentic_tools_no_web(): the standard set minus that server tool.
- openai_agentic_loop(): forked rather than parameterised, so agentic_loop — which
carries every round-7/8/9 fix — is provably untouched. Same envelopes, same state
keys, same consent policy (ask_all / escalate / builtin / always-allow), same
client-bridge contract, same run-progress ledger, same 12-iteration cap.
- ADR-0005 mirrored on this wire: parallel_tool_calls:false is sent explicitly, and
if a provider ignores it we honour the FIRST call and echo only that one, so the
conversation we send is never self-contradictory. The drop is logged loudly.
- The assistant turn echoes the provider's own content bytes (json_get_raw), so a
JSON null stays null and nothing is lost to a decode/re-encode round trip.
- Tool results are embedded already-escaped (dispatch_tool json_safe's them);
truncation trims a dangling escape so a cut can't invalidate the body.
- bridge_save() gains a "wire" scalar and agentic_resume branches on it, so a
suspended turn resumes on the wire it suspended on. Legacy blobs (no field) resume
as anthropic. The field is read from the blob's SCALAR HEAD only — an unbounded
first-match scan would run on into messages_raw, which is model-controlled, and
that is exactly the round-9 resume defect. Pinned by a test.
- Three fork sites: handle_chat_agentic, handle_dharma_room_turn_agentic,
agentic_resume. Tool assembly is computed once per lane at both entry points
(it makes an HTTP call to the connector bridge; it was being paid for twice).
TOOLING THAT DID NOT EXIST
- tests/run-el-test.sh — engine tests were never runnable: elc is a compiler, it
emits C and exits. This emits the test to C, compiles soul.c with main renamed
away, links the rest + the repo-pinned runtime, and runs it. It also COMPUTES THE
VERDICT, because every counted test file's "N passed, M failed" summary is a
permanent 0/0 — the counters increment inside if BLOCKS, which El scoping
discards (9 files; real fix filed as neuron#116). Proven to discriminate with a
deliberately-broken assertion.
- tests/gate-openai/ — deterministic OpenAI-dialect provider stub + scenarios +
driver + hostile modes, and a strict request validator that rejects any
Anthropic-shaped field so dialect leakage fails loudly.
VERIFICATION (rungs named)
- E2E-VERIFIED against a LIVE provider (Anthropic's OpenAI-compatible endpoint,
confirmed live): real answer; a tool call whose out-of-root path was DENIED by the
guard, after which the model refused to claim success ("I won't tell you I did it,
because I didn't"); then a valid path -> file physically on disk with exact content,
honest reply, ledger with per-round entries + {done:true}.
- Deterministic lane gate: 11/12 in both consent configurations (bridge + local);
hostile providers produce no hang and no fabricated answer; the 12-iteration cap
trips with its honest message. The one FAIL is oa-tools-off and is NOT this port —
see "Known, not fixed here".
- ANTHROPIC LANE UNCHANGED: gate9 32/32 on this build and on the pinned round-9
brain; request bytes differ only within the noise band that two runs of the
UNMODIFIED brain also produce (proven with a baseline-vs-baseline control), and
the preload sections — the shared code touched here — are byte-identical.
The rig discriminates: the round-8 brain scores 24/32 on it.
- verify-soul-contract.sh: PASS (27/27 routes, no hard-deletes).
- Unit: test_bridge_serialization 36/36 (incl. 8 new wire/field-order assertions),
test_utf8_slice 18/18, test_agentic_tools 18 PASS / 0 FAIL / 3 documented skips.
KNOWN, NOT FIXED HERE (deliberate)
- Tools:Off on an OpenAI provider still fails: the non-agentic path goes through the
el-runtime provider chain, which appends /v1/chat/completions to a base URL that
already ends in /v1 -> /v1/v1/... 404. Runtime/plain-chat territory, untouched
mid-beta. Note openai_chat_complete() has zero callers — that lane is served
entirely by the runtime chain.
- The 12-iteration cap does not bound a chain of BRIDGED tools (iteration is
per-invocation and resume starts fresh). Parity with the Anthropic lane.
- run_progress resets on each resume, so a client rendering cumulative steps across a
consent pause sees earlier legs vanish. Parity with the Anthropic lane.
- verify-soul-contract.sh needs bash >= 4; under macOS's stock bash 3.2 it dies
instantly with a FALSE red ("local: -n: invalid option").
- Groq-specific live E2E not run: no Groq key exists on this machine.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
94 lines
5.8 KiB
Plaintext
94 lines
5.8 KiB
Plaintext
// auto-generated by elc --emit-header - do not edit
|
|
extern fn chat_default_model() -> String
|
|
extern fn engram_numeric_valid(s: String) -> Bool
|
|
extern fn parse_float_x100(s: String) -> Int
|
|
extern fn engram_score_node(node_json: String) -> Int
|
|
extern fn engram_render_node(node_json: String) -> String
|
|
extern fn engram_render_nodes(nodes_json: String) -> String
|
|
extern fn engram_dedup_nodes(nodes_json: String) -> String
|
|
extern fn engram_compile_ranked(nodes_json: String, max_nodes: Int) -> String
|
|
extern fn engram_split_topics(message: String) -> String
|
|
extern fn engram_extract_entities(message: String) -> String
|
|
extern fn engram_detect_recall_intent(message: String) -> Bool
|
|
extern fn engram_is_continuation(message: String, hist_len: Int) -> Bool
|
|
extern fn engram_compile_multi(topic: String) -> String
|
|
extern fn engram_nodes_merge(a: String, b: String) -> String
|
|
extern fn id_in_seen(node_id: String, seen: String) -> Bool
|
|
extern fn add_to_seen(seen: String, node_id: String) -> String
|
|
extern fn engram_extract_ids(nodes_json: String) -> String
|
|
extern fn affective_node_ts(node_json: String) -> Int
|
|
extern fn engram_compile(intent: String) -> String
|
|
extern fn distill_transcript(transcript: String) -> String
|
|
extern fn json_safe(s: String) -> String
|
|
extern fn current_engine_note(model: String) -> String
|
|
extern fn bounded_persona_floor() -> String
|
|
extern fn operator_identity_block() -> String
|
|
extern fn build_system_prompt(ctx: String, chat_mode: Bool) -> String
|
|
extern fn hist_append(hist: String, role: String, content: String) -> String
|
|
extern fn conv_hist_key(session_id: String) -> String
|
|
extern fn conv_hist_label(session_id: String) -> String
|
|
extern fn is_utility_request(body: String, session_id: String) -> Bool
|
|
extern fn provenance_scan_urls(arr: String, acc: String) -> String
|
|
extern fn provenance_add_sources(block: String, btype: String, has_cit: Bool, cit_raw: String, acc: String) -> String
|
|
extern fn provenance_names(tools_used: String) -> String
|
|
extern fn text_join_sep(accumulated: String, incoming: String, after_interruption: Bool) -> String
|
|
extern fn receipt_rule() -> String
|
|
extern fn receipt_strip(s: String) -> String
|
|
extern fn tool_receipt(tools_used: String, sources: String) -> String
|
|
extern fn hist_trim(hist: String) -> String
|
|
extern fn hist_trim_with_bell_guard(hist: String) -> String
|
|
extern fn clean_llm_response(s: String) -> String
|
|
extern fn conv_history_persist(session_id: String, hist: String) -> Void
|
|
extern fn conv_history_load(session_id: String) -> String
|
|
extern fn conv_history_record(session_id: String, user_msg: String, assistant_msg: String, receipt: String) -> Void
|
|
extern fn conv_history_block(session_id: String) -> String
|
|
extern fn layered_generate(prompt: String, imprint_id: String, session_id: String) -> String
|
|
extern fn session_preload_bullets(nodes: String, max_bullets: Int, snip_len: Int) -> String
|
|
extern fn affective_context_prefix() -> String
|
|
extern fn handle_chat(body: String) -> String
|
|
extern fn handle_see(body: String) -> String
|
|
extern fn studio_tools_json() -> String
|
|
extern fn agentic_api_key() -> String
|
|
extern fn llm_base_url() -> String
|
|
extern fn llm_wire_format() -> String
|
|
extern fn json_escape(s: String) -> String
|
|
extern fn openai_chat_complete(model: String, base_url: String, api_key: String, safe_sys: String, messages_json: String) -> String
|
|
extern fn openai_tools_json(tools_anthropic: String) -> String
|
|
extern fn utf8_safe_slice(s: String, n: Int) -> String
|
|
extern fn json_trim_dangling_escape(s: String) -> String
|
|
extern fn agentic_tools_no_web() -> String
|
|
extern fn openai_agentic_loop(session_id: String, model: String, safe_sys: String, tools_json: String, messages_in: String, tools_log_in: String) -> String
|
|
extern fn agentic_tools_literal() -> String
|
|
extern fn web_search_tool_json() -> String
|
|
extern fn strip_client_web_search(tools_inner: String) -> String
|
|
extern fn agentic_tools_with_web() -> String
|
|
extern fn connector_tools_json() -> String
|
|
extern fn agentic_tools_all() -> String
|
|
extern fn call_mcp_bridge(tool_name: String, tool_input: String) -> String
|
|
extern fn tool_auto_approved(tool_name: String) -> Bool
|
|
extern fn call_neuron_mcp(tool_name: String, args: String) -> String
|
|
extern fn agent_workspace_root() -> String
|
|
extern fn path_within_root(path: String, root: String) -> Bool
|
|
extern fn resolve_in_root(path: String, root: String) -> String
|
|
extern fn run_command_is_readonly(cmd: String) -> Bool
|
|
extern fn cmd_abs_escape_at(cmd: String, root: String, needle: String) -> Bool
|
|
extern fn run_command_guard(cmd: String, root: String) -> String
|
|
extern fn classify_tool_risk(tool_name: String, tool_input: String) -> String
|
|
extern fn dispatch_tool(tool_name: String, tool_input: String) -> String
|
|
extern fn is_builtin_tool(tool_name: String) -> Bool
|
|
extern fn next_bridge_id() -> String
|
|
extern fn handle_chat_plan(body: String) -> String
|
|
extern fn handle_chat_agentic(body: String) -> String
|
|
extern fn agentic_loop(session_id: String, model: String, safe_sys: String, tools_json: String, messages_in: String, h: Map, tools_log_in: String) -> String
|
|
extern fn bridge_save(session_id: String, model: String, safe_sys: String, tools_json: String, messages: String, tools_log: String, tool_use_id: String, wire: String) -> Bool
|
|
extern fn agentic_resume(session_id: String, tool_use_id: String, content: String) -> String
|
|
extern fn handle_tool_result(session_id: String, body: String) -> String
|
|
extern fn handle_chat_as_soul(body: String) -> String
|
|
extern fn handle_dharma_room_turn(body: String) -> String
|
|
extern fn handle_dharma_room_turn_agentic(body: String) -> String
|
|
extern fn session_summary_write(summary_text: String) -> String
|
|
extern fn session_summary_write_dated(summary_text: String, label: String) -> String
|
|
extern fn session_summary_autogenerate(hist: String) -> String
|
|
extern fn auto_persist(req: String, resp: String) -> Void
|
|
extern fn strengthen_chat_nodes(activation_nodes: String) -> Void
|