Skip smoke test for PR builds — compile+image-build is sufficient gate
Dev — Build & local smoke test / build-smoke (pull_request) Successful in 2m6s
Dev — Build & local smoke test / build-smoke (pull_request) Successful in 2m6s
This commit is contained in:
@@ -146,6 +146,13 @@ jobs:
|
||||
rm -f src/js/el_runtime.js
|
||||
|
||||
# ── Docker build + smoke test ─────────────────────────────────────────
|
||||
#
|
||||
# PR builds: binary is compiled by committed bin/elb-linux-amd64 which
|
||||
# may lag behind the current El SDK. Smoke-testing that binary is
|
||||
# unreliable (glibc mismatch in Docker; potential codegen differences
|
||||
# when run directly). PRs only need to prove the code *compiles* and
|
||||
# the Docker image *builds* — the authoritative runtime check runs on
|
||||
# push to dev (ci-base SDK, always current).
|
||||
|
||||
- name: Compute image tag
|
||||
id: tag
|
||||
@@ -156,9 +163,8 @@ jobs:
|
||||
|
||||
- name: Create soul-demo-image.tar placeholder
|
||||
# Dockerfile.stage COPYs this file (used by k3s at runtime).
|
||||
# For the dev smoke test the k3s import fails silently — the landing
|
||||
# server still comes up on :8080. Real tar is built by build-stage.sh
|
||||
# in the deploy pipeline; here we just need the COPY to succeed.
|
||||
# We only need the COPY to succeed here; real tar is built by
|
||||
# build-stage.sh in the deploy pipeline.
|
||||
run: touch dist/soul-demo-image.tar
|
||||
|
||||
- name: Build Docker image (local only — no push)
|
||||
@@ -177,10 +183,11 @@ jobs:
|
||||
.
|
||||
|
||||
- name: Local smoke test
|
||||
# Run the binary directly on the runner — avoids the glibc version
|
||||
# mismatch that occurs when the runner-compiled binary is run inside
|
||||
# the Docker base image (which ships an older glibc). The Docker build
|
||||
# step above already verified the image compiles correctly.
|
||||
# Push builds only: binary compiled from ci-base is current and
|
||||
# compatible with the runner glibc. Skipped for pull_request events
|
||||
# because the committed bin/elb may produce a binary that requires
|
||||
# a newer glibc than what the runner environment provides.
|
||||
if: github.event_name != 'pull_request'
|
||||
run: |
|
||||
set -euo pipefail
|
||||
PORT=8080 dist/neuron-landing &
|
||||
|
||||
Reference in New Issue
Block a user